Ticket #4674 (assigned defect)

Opened 1 month ago

Last modified 2 weeks ago

[with patch and spkg, needs review] update to latest jsmath (3.6 at the moment)

Reported by: mabshoff Assigned to: jason (accepted)
Priority: major Milestone: sage-3.4
Component: notebook Keywords:
Cc:

Description (Last modified by mabshoff)

As the subject says. Note that the use of a better load mechanism available in jsmath 3.6 or higher is #4714.

Cheers,

Michael

Attachments

jsmath-spkg.patch (4.0 kB) - added by jason on 12/20/2008 12:51:28 PM.

Change History

12/02/2008 08:05:24 AM changed by mabshoff

  • description changed.
  • summary changed from use easy/load.js when loading jsmath to use easy/load.js when loading jsmath and update to latest jsmath (3.6 at the moment).

12/02/2008 08:06:11 AM changed by jason

jsMath is version 3.6a now: http://sourceforge.net/project/showfiles.php?group_id=172663

12/02/2008 08:06:16 AM changed by jason

  • owner changed from boothby to jason.
  • status changed from new to assigned.

12/02/2008 08:07:13 AM changed by jason

#4267 is also related.

12/02/2008 08:08:21 AM changed by jason

#4267 is related in that it already contains an spkg for the updated jsmath.

12/04/2008 10:06:39 AM changed by jason

#3768 is the ticket for updating jsmath.

12/05/2008 01:53:28 AM changed by jason

The jsmath spkgs are here:

http://sage.math.washington.edu/home/jason/notebook/jsmath-3.6a.spkg

http://sage.math.washington.edu/home/jason/notebook/jsmath-image-fonts-1.3p0.spkg

12/05/2008 01:54:49 AM changed by jason

  • summary changed from use easy/load.js when loading jsmath and update to latest jsmath (3.6 at the moment) to [with patch and spkg ] use easy/load.js when loading jsmath and update to latest jsmath (3.6 at the moment).

The obsolete jsmath directory should be deleted out of the extcode repository as well.

12/05/2008 02:08:53 AM changed by jason

I also cleaned up places where the JSMATH variable was set. There is no purpose for the variable, since jsmath is a standard part of Sage (it is always installed).

12/05/2008 02:09:04 AM changed by jason

  • summary changed from [with patch and spkg ] use easy/load.js when loading jsmath and update to latest jsmath (3.6 at the moment) to [with patch and spkg, needs review] use easy/load.js when loading jsmath and update to latest jsmath (3.6 at the moment).

12/05/2008 02:09:17 AM changed by jason

  • summary changed from [with patch and spkg, needs review] use easy/load.js when loading jsmath and update to latest jsmath (3.6 at the moment) to [with patch and spkg, needs review] update to latest jsmath (3.6 at the moment).

12/05/2008 02:11:12 AM changed by jason

See #4714 for the loading part of this ticket.

12/05/2008 02:23:22 AM changed by mabshoff

  • description changed.

12/06/2008 02:52:49 PM changed by was

  • summary changed from [with patch and spkg, needs review] update to latest jsmath (3.6 at the moment) to [with patch and spkg, needs work] update to latest jsmath (3.6 at the moment).

I also cleaned up places where the JSMATH variable was set. There is no purpose for the variable, since jsmath is a standard part of Sage (it is always installed).

jsmath was standard ever since we used it with the notebook. That wasn't the point of the variable. The point is that it gives users a way to turn of use of jsmath entirely, which may be a very good idea in some settings (e.g., low bandwidth notebook servers). Basically, for no good reason I think you've removed functionality. Make a new patch that just has the first change in the first version of the patch you attached above.

12/20/2008 12:51:28 PM changed by jason

  • attachment jsmath-spkg.patch added.

12/20/2008 12:54:43 PM changed by jason

  • summary changed from [with patch and spkg, needs work] update to latest jsmath (3.6 at the moment) to [with patch and spkg, needs review] update to latest jsmath (3.6 at the moment).

Okay, I updated the jsmath-spkg.patch to address the concerns above.

Note that functionality spoken of in the review has been broken for a while. I think this is because run_notebook.py automatically sets the JSMATH variable to True, no matter what. However, fixing this so that it works is a different issue than this ticket.

12/24/2008 09:17:04 AM changed by mabshoff

Looks good to me. Some review changes were made at

Please rereview, the changes are fairly minor. I mostly fixed stylistic issues as well as made sure that old jsmath installs (including their fonts) are cleaned out to avoid problems due to left over cruft. This means that an upgrade to jsmath deletes also the image fonts, but that seems a worthwhile price to pay.

For the record: jsmath-3.6a.p0.spkg is going into standard Sage while jsmath-image-fonts-1.3p1.spkg should go into the optional repo.

Cheers,

Michael