Ticket #4550 (new task)

Opened 2 months ago

Last modified 3 weeks ago

[with patch, needs review] notebook -- removed unused NotebookSettings and UserSetting related code

Reported by: TimothyClemans Assigned to: boothby
Priority: trivial Milestone: sage-3.4
Component: notebook Keywords:
Cc:

Description

Depends on #4089

Attachments

trac_4550.patch (4.7 kB) - added by mhansen on 12/02/2008 06:48:35 PM.
sage-4550.patch (4.7 kB) - added by TimothyClemans on 12/21/2008 12:59:05 PM.

Change History

11/19/2008 09:26:00 AM changed by TimothyClemans

  • summary changed from notebook -- removed unused NotebookSettings and UserSetting related code to [with patch, needs review] notebook -- removed unused NotebookSettings and UserSetting related code.

12/02/2008 06:48:35 PM changed by mhansen

  • attachment trac_4550.patch added.

12/06/2008 01:16:36 PM changed by was

Just out of curiosity, what is the justification for removing this code, besides "it currently isn't being used"? For example, did you (Timothy) write new settings code that will replace this? I think maybe (?) I wrote this code a long time ago as the framework that user and notebook settings code would go into, but never flushed that out. So unless there is no code that is going to replace or some new design or *something*, I would like some sort of explanation about what the point of this is.

12/06/2008 06:04:26 PM changed by TimothyClemans

I implemented Notebook and User settings without using the pre-existing framework. User Settings is already in Sage and Notebook Settings is #4551

12/21/2008 12:59:05 PM changed by TimothyClemans

  • attachment sage-4550.patch added.

12/21/2008 12:59:32 PM changed by TimothyClemans

apply sage-4550.patch (rebased)