Ticket #4305 (new defect)

Opened 3 months ago

Last modified 1 month ago

[with patch, needs work] move finite fields into their own directory

Reported by: robertwb Assigned to: tbd
Priority: major Milestone: sage-3.4
Component: algebra Keywords:
Cc:

Description

This is in anticipation of much re-factoring and refinement.

Attachments

4305-move-finite-field.patch (65.7 kB) - added by robertwb on 10/15/2008 01:52:02 PM.
4305-ff-docs.patch (1.4 kB) - added by robertwb on 10/15/2008 02:00:08 PM.
apply to docs repo
trac_4305_review.patch (3.0 kB) - added by mabshoff on 10/16/2008 03:19:27 AM.

Change History

10/15/2008 01:52:02 PM changed by robertwb

  • attachment 4305-move-finite-field.patch added.

10/15/2008 02:00:08 PM changed by robertwb

  • attachment 4305-ff-docs.patch added.

apply to docs repo

10/15/2008 02:05:44 PM changed by mabshoff

  • summary changed from [with patch, needs review] move finite fields into their own directory to [with patch, positive review] move finite fields into their own directory.

Looks good to me - damn the torpedoes :)

Cheers,

Michael

10/16/2008 02:30:52 AM changed by mabshoff

  • summary changed from [with patch, positive review] move finite fields into their own directory to [with patch, needs work] move finite fields into their own directory.
  • milestone changed from sage-3.1.4 to sage-3.2.

Due to trouble when building the tree with the patch applied on sage.math, i.e. finite_field_givaro not being found, this patch unfortunately needs work :(

I will attach a reviewer patch shortly once I have proper net again.

Cheers,

Michael

10/16/2008 03:19:27 AM changed by mabshoff

  • attachment trac_4305_review.patch added.

12/05/2008 01:58:41 AM changed by mabshoff

Robert,

is anything going on here? I am not sure how much happened to the finite fields since SD 10, but that patch here certainly has gone stale. Should you plan to work on this in the short term please ping me so we can coordinate the big move. Otherwise we should delete the patches and wait until someone tackles this again.

Cheers,

Michael

(follow-up: ↓ 5 ) 12/07/2008 01:41:47 AM changed by robertwb

  • milestone changed from sage-3.2.2 to sage-3.3.

I'm hoping to have a little time to look into this over the break. Don't delete the patches just yet.

(in reply to: ↑ 4 ) 12/07/2008 01:51:08 AM changed by mabshoff

Replying to robertwb:

I'm hoping to have a little time to look into this over the break. Don't delete the patches just yet.

Ok, I just think that a lot of this patch needs to be rebased, so it might be a good idea to start over, but we will see. One aspect that puzzles me to this day is that we never got it to work on any other system but your own.

One issue that likely will need addressing is pickling issues.

Cheers,

Michael