Ticket #4069 (closed defect: fixed)

Opened 4 months ago

Last modified 2 weeks ago

[with patch, positive review] support "application shortcut" in chrome and gears

Reported by: schilly Assigned to: schilly
Priority: trivial Milestone: sage-3.2.3
Component: notebook Keywords:
Cc:

Description

Some additional lines in the html-header enable proper handling of the sage notebook as a "desktop application". There, all elements from the browser UI are removed and it looks like an application with a shortcut on the desktop or start menu. This is probably more widespread used once HTML 5 ideas are used in other browsers as well.

I'll attach nice icons and a text to this ticket.

read more here @google chrome webmasters/section 15. and the link to the gears desktop api

Attachments

shortcut_extcode.patch (26.4 kB) - added by ahupfer on 11/02/2008 01:22:39 PM.
shortcut patch for extcode repository
shortcut_sage.patch (1.3 kB) - added by ahupfer on 11/02/2008 01:23:42 PM.
shortcut patch for main repository
sage-4069_2.patch (1.8 kB) - added by TimothyClemans on 12/22/2008 10:35:12 AM.

Change History

10/31/2008 12:26:23 PM changed by ahupfer

  • summary changed from support "application shortcut" in chrome and gears to [with patch, needs review] support "application shortcut" in chrome and gears.

Implements a "Create Shortcut" link that is displayed in in the "list worksheets" view that is displayed if the user has installed Google Gears.

The images included need to be places in the data/extcode/notebook/images folder and provide the application shortcut image requested by gears.

11/02/2008 01:22:39 PM changed by ahupfer

  • attachment shortcut_extcode.patch added.

shortcut patch for extcode repository

11/02/2008 01:23:42 PM changed by ahupfer

  • attachment shortcut_sage.patch added.

shortcut patch for main repository

11/09/2008 06:33:41 PM changed by TimothyClemans

The images aren't in either of the patches. I think you have to do hg export --git

11/09/2008 07:21:54 PM changed by TimothyClemans

Depends on #3950

11/09/2008 07:22:32 PM changed by TimothyClemans

  • summary changed from [with patch, needs review] support "application shortcut" in chrome and gears to [with patch, positive review] support "application shortcut" in chrome and gears.

11/09/2008 07:47:50 PM changed by TimothyClemans

Don't apply sage-4069_2.patch if #3950 not in. The first two patches work with the lastest sage-3.2. The last patch makes this work when #3950 is merged in.

11/25/2008 04:31:34 AM changed by mabshoff

Mike,

any news on the ticket reviews you promised to Timothy? I want to hold off on this merge until #3950 is in, so until then this lovely ticket will bitrot :(

Cheers,

Michael

11/28/2008 12:41:56 AM changed by mabshoff

  • summary changed from [with patch, positive review] support "application shortcut" in chrome and gears to [with patch, positive review] support "application shortcut" in chrome and gears (waiting on #3950).

12/07/2008 03:46:58 AM changed by mabshoff

  • summary changed from [with patch, positive review] support "application shortcut" in chrome and gears (waiting on #3950) to [with patch, needs rebase] support "application shortcut" in chrome and gears.

Now that #3950 is in this one can go in, but we need a rebase: 

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.2.2.alpha1/devel/sage$ patch -p1 --dry-run < trac_4069_shortcut_sage.patch 
patching file sage/server/notebook/notebook.py
Hunk #2 FAILED at 1319.
Hunk #3 succeeded at 1324 (offset -44 lines).
1 out of 3 hunks FAILED -- saving rejects to file sage/server/notebook/notebook.py.rej

Once it is rebased it will go in.

Cheers,

Michael

12/22/2008 10:35:12 AM changed by TimothyClemans

  • attachment sage-4069_2.patch added.

12/22/2008 10:35:48 AM changed by TimothyClemans

  • summary changed from [with patch, needs rebase] support "application shortcut" in chrome and gears to [with patch, positive review] support "application shortcut" in chrome and gears.

Rebased

12/22/2008 10:36:40 AM changed by TimothyClemans

Apply shortcut_extcode.patch and sage-4069_2.patch

12/23/2008 01:03:07 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from sage-3.4 to sage-3.2.3.

Merged shortcut_extcode.patch and sage-4069_2.patch in Sage 3.2.3.alpha0