Ticket #3971 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

[with patch; positive review] hidden markov models -- implement nsteps and log_likelihood_cutoff

Reported by: was Assigned to: cwitty
Priority: major Milestone: sage-3.1.2
Component: misc Keywords:
Cc:

Description

I forgot to implement the nsteps and log_likelihood_cuttoff parameters for discrete hidden markov models, despite documenting them as implemented. The attached short patch fixes this oversight.

Attachments

sage-3971.patch (4.0 kB) - added by was on 08/27/2008 04:40:00 PM.

Change History

08/27/2008 04:40:00 PM changed by was

  • attachment sage-3971.patch added.

08/27/2008 11:11:09 PM changed by jkantor

  • summary changed from [with patch; needs review] hidden markov models -- implement nsteps and log_likelihood_cutoff to [with patch; positive review] hidden markov models -- implement nsteps and log_likelihood_cutoff.

This looks good to me. No real comments but positive review

08/28/2008 05:00:19 AM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.1.2.alpha2