Ticket #3967 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

[with patch, with positive review] Totallyreal "just print" feature added

Reported by: jvoight Assigned to: jvoight
Priority: minor Milestone: sage-3.1.3
Component: number theory Keywords:
Cc: craigcitro

Description

I added a small feature to "just print" long lists of fields in totallyreal rather than storing them to memory. Patch attached.

Attachments

9865.patch (3.8 kB) - added by jvoight on 08/27/2008 10:22:02 AM.
trac-3967-rebase.patch (5.6 kB) - added by craigcitro on 09/21/2008 10:28:44 PM.
Rebased John's patch for 3.1.2, depends on trac #4155 (both patches)

Change History

08/27/2008 10:22:02 AM changed by jvoight

  • attachment 9865.patch added.

08/27/2008 12:10:38 PM changed by mabshoff

  • cc set to craigcitro.
  • summary changed from Totallyreal "just print" feature added to [with patch, needs review] Totallyreal "just print" feature added.
  • milestone set to sage-3.1.2.

Craig,

you are the canonical person to review this small patch :)

Cheers,

Michael

09/20/2008 01:44:20 AM changed by craigcitro

  • summary changed from [with patch, needs review] Totallyreal "just print" feature added to [with patch, with positive review] Totallyreal "just print" feature added.

This looks good. I went ahead and re-based this on 3.1.2 with my patch from #4155 applied, since it makes sense to apply that first.

John, you should at least glance to make sure I didn't mess anything up rewriting the patch, just for the sake of having a second set of eyes look at it.

09/20/2008 10:04:30 AM changed by jvoight

  • owner changed from was to jvoight.
  • status changed from new to assigned.

Yes, all looks well. I'm reviewing #4155 now. JV

09/20/2008 10:05:22 AM changed by jvoight

  • status changed from assigned to closed.
  • resolution set to worksforme.

09/20/2008 10:05:35 AM changed by jvoight

  • status changed from closed to reopened.
  • resolution deleted.

09/20/2008 10:06:56 AM changed by jvoight

Sorry to be such a tool about changing the status of this ticket. I wasn't sure what to set it to so as to indicate that it is ready for inclusion, once #4155 gets resolved. JV

09/20/2008 01:45:30 PM changed by mabshoff

Hi John,

FYI: the release manager closes a ticket once it is merged/determined to be invalied/etc.

Cheers,

Michael

09/21/2008 11:08:41 AM changed by mabshoff

Craig,

the rebased patch is broken: Toward the end you do not rename jp to jp_file and hence things do not compile. I will fix this in my tree and do some valgrinding.

Cheers,

Michael

09/21/2008 01:20:21 PM changed by craigcitro

Oops ... you were absolutely right, mabshoff. I've fixed it up, and tested it out.

09/21/2008 10:28:44 PM changed by craigcitro

  • attachment trac-3967-rebase.patch added.

Rebased John's patch for 3.1.2, depends on trac #4155 (both patches)

09/22/2008 05:09:36 PM changed by mabshoff

  • status changed from reopened to closed.
  • resolution set to fixed.

Merged trac-3967-rebase.patch in Sage 3.1.3.alpha1