Ticket #3960 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

[with patch, positive review] "edit this" on published worksheets doesn't work anymore in 3.1.1

Reported by: nbruin Assigned to: mhansen
Priority: blocker Milestone: sage-3.1.2
Component: notebook Keywords:
Cc:

Description

Way to reproduce:

  • start notebook
  • create worksheet
  • publish worksheet
  • go to "published worksheets"
  • click published worksheet

result:

"edit this" or "edit a copy" link lead to another "published" version, not a normal worksheet

expected result:

an editable worksheet

NOTE: This worked properly in 3.0.6

Attachments

trac_3960.patch (0.7 kB) - added by mhansen on 09/03/2008 06:35:41 PM.

Change History

08/27/2008 12:56:02 AM changed by mabshoff

  • priority changed from critical to blocker.

This is definitely a blocker for 3.1.2.

Cheers,

Michael

08/27/2008 09:21:24 AM changed by itolkov

I believe that this is because somewhere the wrong username is taken into account. Here is an example: publish a worksheet, and navigate to it. The link should say "edit this", not "edit a copy".

Alternatively, I found that the username passed to worksheet_html() in notebook.py is "pub", but was unable to find the source of the problem.

09/02/2008 05:53:00 PM changed by mhansen

  • owner changed from boothby to mhansen.
  • status changed from new to assigned.

09/03/2008 06:35:41 PM changed by mhansen

  • attachment trac_3960.patch added.

09/03/2008 06:35:54 PM changed by mhansen

  • summary changed from "edit this" on published worksheets doesn't work anymore in 3.1.1 to [with patch, needs review] "edit this" on published worksheets doesn't work anymore in 3.1.1.

09/03/2008 06:43:55 PM changed by mabshoff

  • summary changed from [with patch, needs review] "edit this" on published worksheets doesn't work anymore in 3.1.1 to [with patch, positive review] "edit this" on published worksheets doesn't work anymore in 3.1.1.

This patch fixes the issue and Mike walked through the code with me. Positive review. Mike is also writing a Selenium doctest for this bug, so we will catch it in the future.

Cheers,

Michael

09/03/2008 07:02:46 PM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged in Sage 3.1.2.rc0