Ticket #3957 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

[with patch, positive review] notebook -- major bug in opening notebooks and plots

Reported by: was Assigned to: boothby
Priority: major Milestone: sage-3.1.2
Component: notebook Keywords:
Cc:

Description 


On Tue, Aug 26, 2008 at 4:53 AM, Stan Schymanski <schymans@gmail.com> wrote:
>
> Dear all,
>
> Is there a way of saving and automatically re-loading plots generated
> in a notebook when I re-open the notebook?

This is *not* by design, and wasn't the case until very recently.  It's a
bug in the notebook that was introduced very recently.  

>
> Currently, when I close and re-open a notebook, all previously
> displayed plots are gone and even Action... -> Evaluate All does not
> bring them back. I have to keep pressing Shift+Return to see the plots
> again, which is very time consuming. I already figured out that the
> combination of save_session and load_session allows me to re-create
> most of my variables and save a lot of computation time, but it still
> does not bring back the plots.
>
> Thanks for  your help!
>
> Stan
>
> PS: sage 3.1.1 on Mac OS 10.4.11

Attachments

trac_3957.patch (1.9 kB) - added by mhansen on 09/08/2008 06:45:07 PM.

Change History

09/08/2008 06:43:38 PM changed by mhansen

  • summary changed from notebook -- major bug in opening notebooks and plots to [with patch, needs review] notebook -- major bug in opening notebooks and plots.

I've posted a patch which fixes this issue and have written the corresponding Selenium test which passes with this patch and fails without it. Some more extensive manual testing should be done to make sure things are be behaving correctly.

09/08/2008 06:45:07 PM changed by mhansen

  • attachment trac_3957.patch added.

09/09/2008 07:08:52 AM changed by TimothyClemans

  • summary changed from [with patch, needs review] notebook -- major bug in opening notebooks and plots to [with patch, positive review] notebook -- major bug in opening notebooks and plots.

I did hand testing of this, and the bug seems to have been resolved.

09/12/2008 06:54:36 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.1.2.rc2

09/14/2008 08:31:02 PM changed by mabshoff

  • milestone changed from sage-3.1.3 to sage-3.1.2.