Ticket #3950 (closed enhancement: fixed)

Opened 3 months ago

Last modified 19 hours ago

[with patch, positive review] notebook -- template(s) for generating worksheet listings

Reported by: TimothyClemans Assigned to: TimothyClemans
Priority: major Milestone: sage-3.2.2
Component: notebook Keywords:
Cc:

Description

Make templates to replace notebook.html_worksheet_list_public and notebook.html_worksheet_list_for_user

Create a new folder to do this. Maybe use {% include %}

Relies on #3949.

Attachments

trac_3950.patch (27.2 kB) - added by mhansen on 12/02/2008 02:31:59 AM.
extcode_3950.patch (2.2 kB) - added by mhansen on 12/02/2008 02:33:36 AM.
trac_3950-2.patch (42.8 kB) - added by mhansen on 12/02/2008 04:43:35 PM.
trac_3950-folded.patch (41.1 kB) - added by mhansen on 12/02/2008 04:45:23 PM.

Change History

09/07/2008 11:28:37 AM changed by TimothyClemans

  • summary changed from notebook -- template(s) for generating worksheet listings to [with patch, do not review] notebook -- template(s) for generating worksheet listings.

10/23/2008 05:01:02 PM changed by mhansen

Timothy, are you planning on finishing this in the near future, or do you want me to?

10/24/2008 03:41:19 AM changed by TimothyClemans

Don't apply extcode_3950.patch. Do apply extcode_3950_1.patch

11/08/2008 05:26:50 PM changed by TimothyClemans

  • summary changed from [with patch, do not review] notebook -- template(s) for generating worksheet listings to [with patch, needs review] notebook -- template(s) for generating worksheet listings.

Apply extcode_3950_1.patch, extcode_3950_2.patch, trac_3950.patch, and sage-3950_part2.patch

11/09/2008 08:17:27 PM changed by TimothyClemans

Also apply sage-3950_part3.patch

11/09/2008 08:31:40 PM changed by TimothyClemans

  • owner changed from boothby to TimothyClemans.
  • status changed from new to assigned.

11/28/2008 01:57:16 PM changed by mhansen

  • summary changed from [with patch, needs review] notebook -- template(s) for generating worksheet listings to [with patch, needs work] notebook -- template(s) for generating worksheet listings.

This should be done in a way such that there is a template for each html_* method in notebook.py (and worksheet.py) and then the templates just use the {%include%} directive to build them out of these pieces. This makes things easy to change / update.

For example, the topbar should be in its own template so that it can be reused by what ever needs it. As it is now, there would be lots of duplicate HTML code floating around.

11/29/2008 03:24:25 PM changed by TimothyClemans

  • summary changed from [with patch, needs work] notebook -- template(s) for generating worksheet listings to [with patch, needs review] notebook -- template(s) for generating worksheet listings.

I haven't made a template for every html_* yet but the worksheet listing template now uses several templates.

12/02/2008 02:31:59 AM changed by mhansen

  • attachment trac_3950.patch added.

12/02/2008 02:33:36 AM changed by mhansen

  • attachment extcode_3950.patch added.

12/02/2008 04:43:35 PM changed by mhansen

  • attachment trac_3950-2.patch added.

12/02/2008 04:45:23 PM changed by mhansen

  • attachment trac_3950-folded.patch added.

12/02/2008 04:50:00 PM changed by mhansen

I attached my changes as trac_3950-2.patch. trac_3950-folded.patch is a patch showing the combined effect of the two patches. It is helpful for reviewing purposes, but the two other ones are the ones that should be applied for credit reasons.

12/02/2008 05:34:04 PM changed by TimothyClemans

  • summary changed from [with patch, needs review] notebook -- template(s) for generating worksheet listings to [with patch, positive review] notebook -- template(s) for generating worksheet listings.

12/04/2008 06:55:37 AM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged all three patches in Sage 3.2.2.alpha0