Ticket #3854 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

[with patch; positive review] interact needs to use "notruncate"

Reported by: rlm Assigned to: itolkov
Priority: major Milestone: sage-3.1.2
Component: interact Keywords:
Cc:

Description

Too many controls results in output truncated errors, but it's the length of the generated html that's tripping the warning... this should be trivial, just add "<!--notruncate-->" to the generated html.

Attachments

sage.patch (1.0 kB) - added by itolkov on 08/14/2008 12:24:35 PM.
trac_3854.patch (1.0 kB) - added by mhansen on 08/26/2008 05:38:20 PM.
trac_3854_doctest-fix.patch (1.5 kB) - added by mabshoff on 08/26/2008 06:47:45 PM.
Trivial patch to fix two doctest failures

Change History

08/14/2008 12:24:35 PM changed by itolkov

  • attachment sage.patch added.

08/14/2008 12:30:27 PM changed by itolkov

  • summary changed from interact needs to use "notruncate" to [with patch; needs review] interact needs to use "notruncate".

08/23/2008 04:24:45 PM changed by malb

  • summary changed from [with patch; needs review] interact needs to use "notruncate" to [with patch; positive review] interact needs to use "notruncate".

looks good, and from what I can see it does what it is supposed to do. I suppose, that it would be kinda hard to write a doctest for it.

08/23/2008 04:29:09 PM changed by rlm

Doctesting could be easy: simply render the html, cut off the initial <html> and ending </html>, and put "...notruncate..." as the output...

08/24/2008 04:11:02 AM changed by malb

Sure, but it wouldn't test the feature that is in discussion, i.e. that notruncate works as expected.

08/24/2008 07:33:15 PM changed by mabshoff

  • summary changed from [with patch; positive review] interact needs to use "notruncate" to [with patch; positive review, needs rebase] interact needs to use "notruncate".

As is the patch does not apply: 

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.1.2.alpha1/devel/sage$ patch -p1 --dry-run < trac_3854_sage.patch 
patching file sage/server/notebook/interact.py
Hunk #1 FAILED at 1397.
1 out of 1 hunk FAILED -- saving rejects to file sage/server/notebook/interact.py.rej

It should be trivial to rebase.

Cheers,

Michael

08/26/2008 05:38:20 PM changed by mhansen

  • attachment trac_3854.patch added.

08/26/2008 05:38:44 PM changed by mhansen

  • summary changed from [with patch; positive review, needs rebase] interact needs to use "notruncate" to [with patch; positive review] interact needs to use "notruncate".

The new patch should apply.

08/26/2008 05:48:22 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.1.2.alpha1

08/26/2008 06:47:45 PM changed by mabshoff

  • attachment trac_3854_doctest-fix.patch added.

Trivial patch to fix two doctest failures

(follow-up: ↓ 9 ) 08/28/2008 05:41:28 PM changed by mabshoff

For the future: please make dependencies between tickets clear. This ticket should have been applied after #3823. We ended up applying them in reverse order and had to rebase them each because the order was inverse.

Please also name the patches properly, i.e. trac_XXXX_description is that is expected.

Cheers,

Michael

(in reply to: ↑ 8 ) 08/29/2008 03:57:43 AM changed by malb

Replying to mabshoff:

Please also name the patches properly, i.e. trac_XXXX_description is that is expected.

Hi there, did we definitely agree on this? I hardly use it and feel stupid if I've missed the point where I was supposed to switch.