Ticket #3823 (closed defect: fixed)

Opened 5 months ago

Last modified 4 months ago

[with patch; positive review] Interact - get rid of default height

Reported by: itolkov Assigned to: itolkov
Priority: minor Milestone: sage-3.1.2
Component: interact Keywords:
Cc:

Description

Interactions have a minimum height of 400px, which consumes space when only part of it is used.

Attachments

sage.patch (1.0 kB) - added by itolkov on 08/12/2008 01:50:13 PM.
trac_3823_sage.patch (1.1 kB) - added by mabshoff on 08/28/2008 05:57:54 PM.

Change History

08/12/2008 01:50:13 PM changed by itolkov

  • attachment sage.patch added.

08/12/2008 01:51:21 PM changed by itolkov

  • summary changed from Interact - get rid of default height to [with patch; needs review] Interact - get rid of default height.

I changed the default height to 20px, since it's probably good to have one.

08/12/2008 11:46:16 PM changed by mabshoff

  • component changed from notebook to interact.

08/27/2008 07:05:58 AM changed by jason

  • summary changed from [with patch; needs review] Interact - get rid of default height to [with patch; positive review] Interact - get rid of default height.

Looks good to me. Positive review.

08/27/2008 02:39:47 PM changed by mabshoff

  • summary changed from [with patch; positive review] Interact - get rid of default height to [with patch; positive review, needs rebase] Interact - get rid of default height.

This does not apply cleanly any more, but should be trivial to rebase: 

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.1.2.alpha2/devel/sage$ patch -p1 < trac_3823_sage.patch 
patching file sage/server/notebook/interact.py
Hunk #1 FAILED at 1397.
1 out of 1 hunk FAILED -- saving rejects to file sage/server/notebook/interact.py.rej

Igor: In the future please name the patches you post trac_XXXX_description.patch.

Cheers,

Michael

08/28/2008 05:57:54 PM changed by mabshoff

  • attachment trac_3823_sage.patch added.

08/28/2008 05:58:22 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.
  • summary changed from [with patch; positive review, needs rebase] Interact - get rid of default height to [with patch; positive review] Interact - get rid of default height.

Merged trac_3823_sage.patch in Sage 3.1.2.alpha2