Ticket #3780 (closed enhancement: fixed)

Opened 5 months ago

Last modified 4 months ago

[with patch, positive review] add fast col_swap method for dense matrices over GF(2).

Reported by: malb Assigned to: malb
Priority: major Milestone: sage-3.1.2
Component: linear algebra Keywords: m4ri
Cc:

Description (Last modified by mhansen)

depends on #3324

Attachments

m4ri_col_swap.patch (2.2 kB) - added by malb on 08/06/2008 09:29:12 AM.

Change History

08/06/2008 09:29:12 AM changed by malb

  • attachment m4ri_col_swap.patch added.

08/06/2008 12:44:28 PM changed by mhansen

  • summary changed from [with patch, depends on #3324 to [with patch, needs review] depends on #3324.

08/06/2008 12:44:58 PM changed by mhansen

  • description changed.
  • summary changed from [with patch, needs review] depends on #3324 to [with patch, needs review] add fast col_swap method for dense matrices over GF(2)..

08/30/2008 05:11:02 PM changed by rlm

  • summary changed from [with patch, needs review] add fast col_swap method for dense matrices over GF(2). to [with patch, positive review] add fast col_swap method for dense matrices over GF(2)..

I haven't tested this, but it looks fine. If it works, apply.

08/30/2008 05:21:10 PM changed by rlm

...other than the missing output from the last doctest! :-[

08/30/2008 05:34:32 PM changed by mabshoff

Note that the doctests only pass with #3376 applied, where the missing output that rlm mentions above is actually added :)

Cheers,

Michael

08/30/2008 05:53:39 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged in Sage 3.1.2.alpha3

08/30/2008 08:55:40 PM changed by mabshoff

Note that the patch attached to this ticket is a diff. I did commit it in Martin's name.

Cheers,

Michael