Ticket #3643 (closed defect: fixed)

Opened 6 months ago

Last modified 1 month ago

[with patch, positive review] re-enable dsage/testdoc.py

Reported by: was Assigned to: gfurnish
Priority: blocker Milestone: sage-3.2.2
Component: dsage Keywords:
Cc:

Description

I disabled dsage/testdoc.py for sage-3.0.5, since that system for doctesting dsage is BROKEN. For example 

sage -t  devel/sage/sage/dsage/tests/testdoc.py
********************************************************************
File "/home/was/build/sage-3.0.4/tmp/testdoc.py", line 14:
   sage: a
Expected:
   5
Got:
   No output.

and this is just a typical timing issue. We have unit tests after all.

Attachments

trac_3643.patch (0.6 kB) - added by gfurnish on 12/09/2008 10:42:37 AM.

Change History

07/11/2008 12:26:44 PM changed by yi

This is fine. I am working hard to fix this in ticket #3600.

12/09/2008 10:42:37 AM changed by gfurnish

  • attachment trac_3643.patch added.

12/09/2008 10:43:35 AM changed by gfurnish

  • owner changed from yi to gfurnish.
  • status changed from new to assigned.
  • summary changed from re-enable dsage/testdoc.py to [with patch, needs review] re-enable dsage/testdoc.py.

This seems to work correctly with #4745 applied, so after discussion with mabshoff perhaps we should reenable the doctest after #4745 to see if we can get it to fail again.

12/11/2008 07:00:06 AM changed by mabshoff

  • summary changed from [with patch, needs review] re-enable dsage/testdoc.py to [with patch, positive review] re-enable dsage/testdoc.py.

Positive review.

Cheers,

Michael

12/11/2008 07:27:18 AM changed by mabshoff

  • status changed from assigned to closed.
  • resolution set to fixed.

Merged in Sage 3.2.2.alpha2