Ticket #3635 (closed defect: fixed)

Opened 5 months ago

Last modified 3 months ago

[with patch, positive review] If m is a matrix, then m.plot() should call matrix_plot

Reported by: jason Assigned to: was
Priority: major Milestone: sage-3.1.2
Component: linear algebra Keywords:
Cc:

Description

Currently this just puts the text description on an empty set of axes.

Attachments

matrix_plot.patch (1.8 kB) - added by malb on 08/18/2008 02:16:48 PM.
matrix_plot-rebased.patch (1.1 kB) - added by jason on 08/27/2008 07:44:02 AM.

Change History

08/18/2008 02:16:48 PM changed by malb

  • attachment matrix_plot.patch added.

08/18/2008 02:17:32 PM changed by malb

  • summary changed from If m is a matrix, then m.plot() should call matrix_plot to [with patch, needs review] If m is a matrix, then m.plot() should call matrix_plot.

The attached patch implements the requested behavior. Jason, do you want to review it?

08/19/2008 06:35:15 PM changed by kcrisman

Whoever reviews it and/or malb should note that the patches to #3853 would imply the call to MatrixPlotFactory? is superfluous (though something may still have to be imported), but of course that patch has not yet been merged either.

08/27/2008 07:44:02 AM changed by jason

  • attachment matrix_plot-rebased.patch added.

08/27/2008 07:46:00 AM changed by jason

  • summary changed from [with patch, needs review] If m is a matrix, then m.plot() should call matrix_plot to [with patch, positive review] If m is a matrix, then m.plot() should call matrix_plot.

Apply the rebased patch *AFTER* the first patch. Sorry, I should have used a better word that rebased.

Works great. Positive review.

08/27/2008 07:47:16 AM changed by jason

Doctests in matrix/matrix2.pyx pass after both patches have been applied.

08/27/2008 03:08:24 PM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Merged both patches in Sage 3.1.2.alpha2