Ticket #3619 (assigned enhancement)

Opened 6 months ago

Last modified 5 months ago

[with patch, needs work] notebook -- record date & time each user logs in

Reported by: TimothyClemans Assigned to: TimothyClemans (accepted)
Priority: major Milestone: sage-3.4
Component: notebook Keywords:
Cc:

Attachments

sage-3619.patch (4.5 kB) - added by TimothyClemans on 08/12/2008 07:22:06 PM.
Depends on #3776

Change History

07/08/2008 04:34:06 PM changed by TimothyClemans

  • owner changed from boothby to TimothyClemans.
  • status changed from new to assigned.

07/10/2008 06:58:25 AM changed by TimothyClemans

  • summary changed from notebook -- record date & time each user logs in to [with patch, needs review] notebook -- record date & time each user logs in.

I couldn't seem to figure out how to get AdminToplevel? to be the toplevel for admins.

(follow-up: ↓ 4 ) 08/10/2008 04:24:15 PM changed by ncalexan

I don't understand what the final comment, about AdminToplevel?, is about.

I worry that we will hang on to thousands of login times with this, which could be memory/disk intensive. Could we agree on the last fifty login times, or the first time ever and then the next 100 or something similar?

Also, there is no way to view this information. Why are we keeping it?

(in reply to: ↑ 3 ) 08/10/2008 09:37:49 PM changed by TimothyClemans

Replying to ncalexan:

I don't understand what the final comment, about AdminToplevel?, is about.

Somehow the user account type for the user admin was getting changed to 'user'. This is no longer a problem because a patch was merged which has account_type returning 'admin' for user admin no matter what.

I worry that we will hang on to thousands of login times with this, which could be memory/disk intensive. Could we agree on the last fifty login times, or the first time ever and then the next 100 or something similar?

We could, but I am very interested in being able to look up all login times for a given user.

Also, there is no way to view this information. Why are we keeping it?

There will be. I just didn't do it because at the time I couldn't figure out the AdminToplevel? problem.

I'll get back to this ticket after thinking more about it. Thanks for reviewing.

08/10/2008 09:38:51 PM changed by TimothyClemans

  • summary changed from [with patch, needs review] notebook -- record date & time each user logs in to [with patch, needs work] notebook -- record date & time each user logs in.

08/12/2008 02:37:41 PM changed by TimothyClemans

  • summary changed from [with patch, needs work] notebook -- record date & time each user logs in to [with patch, needs review] notebook -- record date & time each user logs in.

How I test this:

(1) I login and then go to sage.math.washington.edu:8999/users # Table of users with two links next to each of them if login recording is on.

(2) I click on "Access" in third column to see login times. The page should be blank if no login times have been recorded.

Login recording is turned off by default. In order to turn it on I do: 

*** WARNING: Notebook must not be running! ***

sage: nb = load('.sage/sage_notebook/nb.sobj', compress=False)
sage: nb.conf()['record_logins'] = True
sage: nb.save(filename='/home/tclemans/.sage/sage_notebook/nb.sobj')

08/12/2008 07:22:06 PM changed by TimothyClemans

  • attachment sage-3619.patch added.

Depends on #3776

08/12/2008 07:28:39 PM changed by TimothyClemans

  • summary changed from [with patch, needs review] notebook -- record date & time each user logs in to [with patch, needs work] notebook -- record date & time each user logs in.