Ticket #3525 (assigned enhancement)

Opened 6 months ago

Last modified 6 months ago

[with patches, don't review] notebook -- new welcome page

Reported by: TimothyClemans Assigned to: TimothyClemans (accepted)
Priority: major Milestone: sage-3.4
Component: notebook Keywords: editor_wstein
Cc:

Description

Take the static page at http://timothyclemans.com/nb_homepage/ and merge it into the Sage Notebook code.

Attachments

extcode-3525.patch (13.1 kB) - added by TimothyClemans on 06/28/2008 01:06:35 AM.
sage-3525.patch (1.7 kB) - added by TimothyClemans on 06/28/2008 01:07:56 AM.
extcode-3525_2.patch (4.4 kB) - added by TimothyClemans on 06/28/2008 03:57:34 AM.
used Tidy to deal with point 5 of Harald's criticism
extcode-3525_3.patch (1.6 kB) - added by TimothyClemans on 06/28/2008 07:50:36 AM.
extcode-3525_4.patch (1.0 kB) - added by TimothyClemans on 06/28/2008 07:58:59 AM.
forgot to change which images are preloaded (the ones for signup and published worksheets)
extcode_combined.patch (47.8 kB) - added by TimothyClemans on 07/07/2008 03:37:03 PM.

Change History

06/28/2008 01:06:35 AM changed by TimothyClemans

  • attachment extcode-3525.patch added.

06/28/2008 01:07:43 AM changed by TimothyClemans

  • owner changed from was to TimothyClemans.
  • status changed from new to assigned.
  • component changed from number theory to notebook.
  • summary changed from notebook -- new welcome page to [with patches, needs review] notebook -- new welcome page.

06/28/2008 01:07:56 AM changed by TimothyClemans

  • attachment sage-3525.patch added.

06/28/2008 01:16:31 AM changed by TimothyClemans

  • keywords set to editor_wstein.

06/28/2008 03:34:59 AM changed by TimothyClemans

From Harald Schilly: 

Looks good, yes. Just small remarks what I would change...

1) The border around the sign-in formular is thin. Why not the same as
those two below? I would suggest to make all three borders small...

2) The top header is an image. The serif-italic letters don't look
very well on my screen. (no subpixel hinting compared to directly
rendered italic letters on my lcd) .. I would suggest to not use an
image, just the text string with a fixed font size (16pt?, italic,
serif) and absolute placement.

3) The forgot password page does not exist. I think, it should look
the same, except the login box and the middle content replaced by an
explanation and so on.

4) maybe less screenshots (just a 3x2 matrix) but with larger images?
so that someone could see more!

5) it's not xhtml valid
I strongly suggest to use xhtml transitional, since this is better for
compatibility and browsers like ie6 work better with that. xhtml
strict is just some sort of a more theoretical wish that will never
come true ;)
but anyways, ending a formular input tag with /> is not ok. browsers
don't understand real xml ...

6) maybe more margin-borders on the left and right side of the middle
content, to give everything a bit more "air" so that it looks less
tight...

greetings Harald


On Sat, Jun 28, 2008 at 08:38, William Stein <wstein@gmail.com> wrote:
> What do you think of
>
> http://timothyclemans.com/nb_homepage/
>
> --
> William Stein
> Associate Professor of Mathematics
> University of Washington
> http://wstein.org
>

06/28/2008 03:57:34 AM changed by TimothyClemans

  • attachment extcode-3525_2.patch added.

used Tidy to deal with point 5 of Harald's criticism

06/28/2008 05:30:57 AM changed by was

  • summary changed from [with patches, needs review] notebook -- new welcome page to [with patches, needs works] notebook -- new welcome page.

06/28/2008 07:04:21 AM changed by TimothyClemans

Regarding the negative review could you tell me if you want all of Harald's suggestions implemented?

1) I can do easily by switching in the css which background is called for a:link and a:hover

2) Maybe do this in another ticket if others also complain

3) A very minimalistic "account recovery" page will be in sage-3.0.4. Anything regarding it should be a different ticket

4) I don't want to change them because A) I like it the way it is B) it would be very time consuming for me

5) Done

6) Sure

06/28/2008 07:21:28 AM changed by was

For a positive review it is enough to do 1, 5, 6.

06/28/2008 07:50:36 AM changed by TimothyClemans

  • attachment extcode-3525_3.patch added.

06/28/2008 07:52:42 AM changed by TimothyClemans

  • summary changed from [with patches, needs works] notebook -- new welcome page to [with patches, needs review] notebook -- new welcome page.

margins increased blue line under interactive computer programming changed to reflect new margins

Border for "Sign up" and "Published worksheets" is now 1px.

06/28/2008 07:58:59 AM changed by TimothyClemans

  • attachment extcode-3525_4.patch added.

forgot to change which images are preloaded (the ones for signup and published worksheets)

06/28/2008 02:47:18 PM changed by TimothyClemans

In extcode-3525_3.patch I see 

diff -r 84e3731cc21b -r 40c4b0aa9491 notebook/images/head.gif
Binary file notebook/images/head.gif has changed

Is the actual image stored in the patch? If not then how do I put package images for inclusion?

07/05/2008 07:37:11 PM changed by TimothyClemans

extcode_combined.patch is a git style patch that should contained the required images

07/07/2008 03:37:03 PM changed by TimothyClemans

  • attachment extcode_combined.patch added.

07/07/2008 03:45:15 PM changed by TimothyClemans

  • summary changed from [with patches, needs review] notebook -- new welcome page to [with patches, don't review] notebook -- new welcome page.

The combined extcode patch is mess. Various fixes aren't in the patch ...