Ticket #3375 (new defect)

Opened 7 months ago

Last modified 7 months ago

[with patch, mixed review] Fix building ntl on Solaris with make and ld

Reported by: fbissey Assigned to: mabshoff
Priority: major Milestone: sage-3.4
Component: build Keywords: editor_mabshoff
Cc:

Description

OK so here is what got me through ntl on David's box. The mfile patch is against the copy in the ntl patch folder not the source. It also patch ntl spkg-install to properly setup and tune ntl as well as cleaning the installation bits introduced to accommodate Tim & I. I guess Tim and I will have to fend for ourselves separately. Also we submitted a lot of patch in the ntl style. Since I used some GNU-ism for building shared objects most of them will have to be revised.

Francois

Attachments

ntl-sun.patch (2.9 kB) - added by fbissey on 06/05/2008 06:23:42 PM.
patch for ntl spkg-install and patch/mfile

Change History

06/05/2008 06:23:42 PM changed by fbissey

  • attachment ntl-sun.patch added.

patch for ntl spkg-install and patch/mfile

06/15/2008 02:52:48 PM changed by craigcitro

  • keywords set to editor_mabshoff.
  • summary changed from Fix building ntl on Solaris with make and ld [with patch needs review] to [with patch needs review] Fix building ntl on Solaris with make and ld.

06/19/2008 09:10:31 PM changed by mabshoff

  • summary changed from [with patch needs review] Fix building ntl on Solaris with make and ld to [with patch, mixed review] Fix building ntl on Solaris with make and ld.

Hi Francois,

Unless I am overlooking something you are removing the "-fPIC" lines from the link phase. Are you sure that will work?

Cheers,

Michael

06/20/2008 01:43:57 AM changed by fbissey

It works all right on linux (no text relocations) but I indeed cannot guaranty it on other platform. I just checked the gcc manual and they recommand passing the PIC flag used during compilation as well when using -shared so best to put it back:

`-shared'

Produce a shared object which can then be linked with other objects to form an executable. Not all systems support this option. For predictable results, you must also specify the same set of options that were used to generate code (-fpic', -fPIC', or model suboptions) when you specify this option.(1)