Ticket #3306 (new defect)

Opened 8 months ago

Last modified 7 months ago

[with patch; mixed review] shared library for symmetrica

Reported by: tabbott Assigned to: mabshoff
Priority: major Milestone: sage-3.4
Component: packages Keywords: editor_mabshoff
Cc: f.r.bissey@massey.ac.nz

Description

I've attached a patch that completely replaces the minimal symmetrica makefile with a much more standard version. It includes a shared library with a soname (the symmetrica version number must be maintained in the package; currently its a variable in the makefile) and adds normal targets like clean, install, etc.

This probably needs to be fixed to do shared libraries correctly for non-linux; I'm not sure exactly how that is supposed to work.

Attachments

symmetrica-shared-library.patch (12.0 kB) - added by tabbott on 05/25/2008 08:46:59 PM.

Change History

05/25/2008 08:46:59 PM changed by tabbott

  • attachment symmetrica-shared-library.patch added.

05/25/2008 08:54:59 PM changed by mabshoff

  • summary changed from [with patch; needs review] shared library for symmetrica to [with patch; positive review] shared library for symmetrica.

The only problem I see here is that "install" is generally not guaranteed to be available, i.e. on Solaris it is commonly called ginstall. I will fix this, but other than that positive review. I am also not quite sure if the Solaris ld can handle this as is, but as I am porting Sage to use the Sun Forte compiler suite I will fix those issues anyway.

Cheers,

Michael

05/25/2008 09:29:43 PM changed by fbissey

Actually on linux (and probably other unix variants) it seems we should use the "-Dunix" flag as well. Mind you after a quick grep through the source only the file de.c make use of that directive. It also has a MSDOS option there may have been a windows variant at some point but I cannot find traces of it on the symmetrica web site.

05/29/2008 07:54:17 AM changed by mabshoff

I am still sitting here pondering whether to apply this patch or not. One issue is that on non-Linux I would need also need to add support for dynamic libraries. But that could be done later, so I will give this another spin and see if it works at least on OSX.

Cheers,

Michael

05/29/2008 08:05:36 AM changed by mabshoff

  • summary changed from [with patch; positive review] shared library for symmetrica to [with patch; mixed review] shared library for symmetrica.

Ok, after looking at this some more I decided that this needs fixing for OSX, Solaris and Cygwin, so I am not applying it as is.

Sorry Tim, but I do not have time right now to fix this properly. Hopefully in the next couple days.

Cheers,

Michael

05/29/2008 08:11:37 AM changed by mabshoff

Sorry for the noise: It would obviously be good for the Debianization project of Sage if this patch were applied. So I would propose that you post a patch that does not touch spkg-install and also does not change the makefile in patches/makefile, i.e. leaves the Sage build as is and moves those changes to the Debian makefile patch. Later on when things are sorted out on other platforms we can then unify the two approaches.

Any such patch would be applied more or less immediately.

Cheers,

Michael

06/19/2008 09:57:35 PM changed by craigcitro

  • keywords set to editor_mabshoff.