Ticket #3297 (new enhancement)

Opened 8 months ago

Last modified 1 month ago

[with proto spkg, needs review, waiting on upstream] Make cddlib produce a shared library

Reported by: fbissey Assigned to: mabshoff
Priority: minor Milestone: sage-3.4
Component: packages Keywords: editor_mabshoff
Cc:

Description

Tim Abbott made a patch to get cddlib to use libtools and easily produce a shared library. Packaging the change for sage means not only patching several Makefile.am file but also adding a file ltmain.sh and regenerating configure.in, configure, aclocal.m4 and several Makefile.in. I attach a tarball containing an updated patch folder and also a patch to spkg-install to use it. The new spkg-install only build shared libraries.

Attachments

patches.tar.gz (268.9 kB) - added by fbissey on 05/25/2008 02:21:01 AM.
new patch folder
spkg-install.patch (484 bytes) - added by fbissey on 05/25/2008 02:21:53 AM.
patch to spkg-install

Change History

05/25/2008 02:21:01 AM changed by fbissey

  • attachment patches.tar.gz added.

new patch folder

05/25/2008 02:21:53 AM changed by fbissey

  • attachment spkg-install.patch added.

patch to spkg-install

05/25/2008 06:26:10 AM changed by mabshoff

  • summary changed from Make ccdlib produce a shared library to [with proto spkg, needs review] Make ccdlib produce a shared library.
  • milestone set to sage-3.0.3.

We should update to the latest cddlib release while we are at it. I see no point in sticking all those files in patches into the mercurial repo since that means checking in 1.3MB of files that will be removed in the next upstream release anyway.

Please do not attach tar.gz archives to trac ticket since a bug prevents the download the easy way, i.e. just follow the link and you will see.

Cheers,

Michael

05/25/2008 06:45:22 AM changed by mabshoff

I just checked and there are other conflicting changes to cddlib-0.94f. So I would greatly prefer for this to go upstream before we merge it back into Sage. The author of cddlib seems to be quite responsive, so let's try that route first.

Cheers,

Michael

05/25/2008 01:49:21 PM changed by fbissey

OK I have a small patch against 0.94f somewhere, not a big change compared to 0.94b but of course everything has to be regenerated which is upstream job anyway. I'll see what I can do.

Cheers, Francois

05/25/2008 03:25:51 PM changed by fbissey

Sent an email upstream with a libtool patch against 0.94f.

Francois

06/15/2008 03:00:39 PM changed by craigcitro

  • keywords set to editor_mabshoff.

06/15/2008 03:00:50 PM changed by craigcitro

  • summary changed from [with proto spkg, needs review] Make ccdlib produce a shared library to [with proto spkg, needs review] Make cddlib produce a shared library.

06/19/2008 09:00:53 PM changed by mabshoff

  • summary changed from [with proto spkg, needs review] Make cddlib produce a shared library to [with proto spkg, needs review, waiting on upstream] Make cddlib produce a shared library.

(follow-up: ↓ 9 ) 08/26/2008 10:24:15 AM changed by mabshoff

Tim,

the latest upstream release is cddlib-094f - did those patches get merged?

Cheers,

Michael

(in reply to: ↑ 8 ) 08/26/2008 04:37:00 PM changed by fbissey

Hi Micheal,

the latest upstream release was already 094f when I filled the bug. I sent a patch against 094f upstream but never got an answer.

Francois

(follow-up: ↓ 11 ) 11/28/2008 02:23:57 PM changed by was

What's up with this? It has been in limbo for 3 months! Somebody do something.

(in reply to: ↑ 10 ) 11/28/2008 02:26:47 PM changed by mabshoff

Replying to was:

What's up with this? It has been in limbo for 3 months! Somebody do something.

Upstream is unresponsive. I don't see the point to copy over a massive amount of changes making the spkg at least twice as large. This is also purely a Debian thing, but we could just ship in place modified sources with instructions on how to get from upstream to this. Once upstream updates (if ever) we could sync.

Cheers,

Michael

12/06/2008 01:47:16 PM changed by was

Upstream is unresponsive. I don't see the point to copy over a massive amount of changes making the spkg at least twice as large. This is also purely a Debian thing, but we could just ship in place modified sources with instructions on how to get from upstream to this. Once upstream updates (if ever) we could sync.

I don't get the sense of any precise plan here, and I'm tempted to close this as invalid? Thoughts?