Ticket #2163 (closed defect: fixed)

Opened 11 months ago

Last modified 1 month ago

[with patch, positive review] .show?? pops up the graphics item as well as the help page

Reported by: jason Assigned to: mhansen
Priority: major Milestone: sage-3.2.2
Component: graphics Keywords:
Cc:

Description

At the command line: 

sage: a=plot(x^2,(x,-1,1))
sage: a.show??
sage: a.show?

In either of the last two commands, the plot pops up on my Ubuntu 7.10 box (as well as the help).

Attachments

trac_2163.patch (5.1 kB) - added by mhansen on 12/02/2008 12:41:48 AM.

Change History

02/14/2008 03:03:05 PM changed by mabshoff

  • milestone set to sage-2.10.2.

02/14/2008 03:03:20 PM changed by mabshoff

  • component changed from algebraic geometry to graphics.

02/14/2008 05:51:20 PM changed by mhansen

  • owner changed from was to mhansen.
  • status changed from new to assigned.

This is due to the following: 

String Form:    <bound method Graphics.show of >

whereas after show_default(False), we get: 

String Form:    <bound method Graphics.show of Graphics object consisting of 1 graphics primitive>

02/14/2008 06:11:23 PM changed by mhansen

This can be fixed if we can tell IPython to set show_default(False) when doing things like repr(a.show)

09/02/2008 05:54:09 PM changed by mhansen

  • status changed from assigned to closed.
  • resolution set to fixed.

09/02/2008 05:54:23 PM changed by mhansen

  • status changed from closed to reopened.
  • resolution deleted.

12/02/2008 12:41:48 AM changed by mhansen

  • attachment trac_2163.patch added.

12/02/2008 12:44:34 AM changed by mhansen

  • summary changed from .show?? pops up the graphics item as well as the help page to [with patch, needs review] .show?? pops up the graphics item as well as the help page.

I had already fixed some problems caused by removing the 'nodoctest' at the top before realizing there's no good way to test the function which I added.

The thing which addresses this ticket is the last hunk at the bottom of the patch.

12/05/2008 12:49:01 AM changed by jason

  • summary changed from [with patch, needs review] .show?? pops up the graphics item as well as the help page to [with patch, positive review] .show?? pops up the graphics item as well as the help page.

This fixes the problem. Tests pass in interpreter.py as well (thanks for fixing all those too!)

Positive review.

12/05/2008 01:37:33 AM changed by mabshoff

  • status changed from reopened to closed.
  • resolution set to fixed.

Merged in Sage 3.2.2.alpha0