Ticket #2073 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

[with patch, positive review] calculus -- get doctest coverage above 50%

Reported by: was Assigned to: was
Priority: major Milestone: sage-2.10.2
Component: calculus Keywords:
Cc:

Attachments

calculus_doctest_improvements.patch (28.6 kB) - added by was on 02/06/2008 01:06:00 AM.
calculus_doctest_improvements-part2.patch (24.8 kB) - added by was on 02/06/2008 01:06:13 AM.
calculus_doctest_improvements-part3.patch (27.5 kB) - added by was on 02/06/2008 01:06:28 AM.
trac-2073-calculus_coverage_part4.patch (21.9 kB) - added by was on 02/06/2008 03:32:27 AM.
2073-random-doctests.patch (4.2 kB) - added by mhansen on 02/07/2008 01:04:57 AM.

Change History

02/06/2008 01:06:00 AM changed by was

  • attachment calculus_doctest_improvements.patch added.

02/06/2008 01:06:13 AM changed by was

  • attachment calculus_doctest_improvements-part2.patch added.

02/06/2008 01:06:28 AM changed by was

  • attachment calculus_doctest_improvements-part3.patch added.

02/06/2008 02:28:41 AM changed by mabshoff

  • summary changed from calculus -- get doctest coverage up to 100% to [with spkg, needs review] calculus -- get doctest coverage up to 100%.

02/06/2008 03:32:27 AM changed by was

  • attachment trac-2073-calculus_coverage_part4.patch added.

02/06/2008 03:33:37 AM changed by was

As of patch four, these are the only remaining public (not underscored) functions without proper documentation in the entire calculus directory: 

Missing documentation:
         * subs(self, *args, **kwds)
         * substitute_over_ring(self, in_dict=None, ring=None, **kwds)
         * str(self, bits=None)
         * maxima_init(x)
         * sys_init(x, system)
         * var_cmp(x,y)
         * CallableSymbolicExpressionRing(args, check=True)
         * foo(n)
         * args(self)
         * plot(self, *args, **kwds)
         * tex_needs_braces(self)
         * simplify(self)


Missing doctests:
         * obj(self)
         * variables(self, vars=tuple([]))
         * integral(self, x=None, a=None, b=None)
         * expression(self)

02/06/2008 08:55:58 AM changed by mabshoff

  • summary changed from [with spkg, needs review] calculus -- get doctest coverage up to 100% to [with patch, needs review] calculus -- get doctest coverage up to 100%.

02/06/2008 10:46:59 AM changed by was

  • summary changed from [with patch, needs review] calculus -- get doctest coverage up to 100% to [with patch, needs review] calculus -- get doctest coverage above 50%.

this is done and ready to be reviewed

02/07/2008 01:04:57 AM changed by mhansen

  • attachment 2073-random-doctests.patch added.

02/07/2008 01:05:18 AM changed by mhansen

  • summary changed from [with patch, needs review] calculus -- get doctest coverage above 50% to [with patch, positive review] calculus -- get doctest coverage above 50%.

Positive review after applying the last patch as well.

02/07/2008 02:05:53 AM changed by mabshoff

  • status changed from new to closed.
  • resolution set to fixed.

Applied all five patches to Sage 2.10.2.alpha0